Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(prost): optimize some Debug representation #18211

Merged
merged 4 commits into from
Sep 2, 2024
Merged

refactor(prost): optimize some Debug representation #18211

merged 4 commits into from
Sep 2, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Aug 23, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Omit optional fields. e.g., a lot of fields in DataType is only for complex types.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

xxchan commented Aug 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @xxchan and the rest of your teammates on Graphite Graphite

@xxchan xxchan requested a review from BugenZhao August 23, 2024 05:57
@xxchan xxchan marked this pull request as ready for review August 23, 2024 05:57
@xxchan xxchan changed the base branch from 08-14-refactor_add_some_comments_for_mv_progress_tracking to main August 23, 2024 06:01
@xxchan xxchan enabled auto-merge August 23, 2024 06:01
@xxchan xxchan added this pull request to the merge queue Sep 2, 2024
Merged via the queue into main with commit b2eea6b Sep 2, 2024
30 of 31 checks passed
@xxchan xxchan deleted the xxxxxxxx branch September 2, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants